search

squishykid / solax

🌞 Solax Inverter API Wrapper
MIT License
100 stars 57 forks source link

Update x1_mini_v34.py #89

Closed jaykijay closed 6 months ago

jaykijay commented 2 years ago

My V34 has a Data Length of 100 when using v3.003.02 Firmware

jefft4 commented 1 year ago

@squishykid - I need this fix applied and pushed through to the HA integration as my X1miniV34 has the same firmware as @jaykijay's. Can I do anything to help to move the PR along?

kdehairy commented 1 year ago

I guess it's pending adding a test. As requested earlier here.

jefft4 commented 1 year ago

I guess it's pending adding a test. As requested earlier here.

I read that, but I'm not sure what that involves... if someone can tell me how to add a test, I have the same inverter so I can do that.

jefft4 commented 1 year ago

Could you please add a test including a response from your inverter under the functional tests? Then we can make sure this keeps working

@squishykid - looking at the files, tests/response.py and tests/expected_values.py for X1_MINI_V34 already match my inverter's results; there are 100 data points in the response definition and the expected values are all present and reasonable.

Darsstar commented 6 months ago

Can be closed, duplicates #139