squix78 / json-streaming-parser

Arduino library for parsing potentially huge json streams on devices with scarce memory
MIT License
208 stars 88 forks source link

Enhancements #18

Open stechio opened 6 years ago

stechio commented 6 years ago

This branch provides several enhancements to existing interfaces and data handling (as a consequence, compatibility with previous versions is BROKEN):

squix78 commented 6 years ago

Hi. Thank you so much for these enhancements. As you mentioned already, they broke compatibility with previous versions and a bunch of other projects/ libraries including many of my own will break with this upgrade. Since Arduino IDE doesn't know version pinning this will lead to many confused people. I will have to orchestrate accepting and releasing this change carefully with the other projects, I hope you understand. But I am very glad that somebody more fluent in C/C++ than me too the time to improve my code!

stechio commented 6 years ago

Hi Daniel. Of course, I understand such kind of changes can't be easily merged into mature projects without disrupting existing dependencies; nevertheless, I meant to apply them for pulling in case you may be interested to open an evolutionary branch (which wouldn't collide with the existing trunk). BTW, I decided to adopt your porting because of its great model (I had just bumped against memory limits over a tons of DOM libs out there) and its clean coding, which allowed me to effortlessly put some candies upon it. So: thank you for your project!

mrcodetastic commented 4 years ago

Good enhancements. I have implemented these in a new fork @ https://github.com/mrfaptastic/json-streaming-parser2