PSR12/OpenTag: improve performance

[jrfnl]

Description

No functional changes at all, just improving performance of the sniff by changing the order of certain checks.

Some benchmarks for this change run using the Performance report (PR #3810):

Command: phpcs -ps . --extensions=php --ignore=/vendor/ --report=performance --standard=psr12

Output for the PSR12.Files.OpenTag sniff:

Result	PHPCS itself	Set of Projects A	Set of Projects B	Set of Projects C
Nr of Files Scanned	614	4115	25546	2250
Before	0.077045 ( 2.3 %)	0.982014 ( 1.9 %)	3.267655 ( 2.1 %)	0.179564 ( 2.1 %)
After	0.000928 ( 0.0 %)	0.013066 ( 0.0 %)	0.091816 ( 0.1 %)	0.109021 ( 1.3 %)

With what the sniff does, the impact is biggest for files/codebases which already comply with the expectations of this sniff.

Suggested changelog entry

PSR12.Files.OpenTag: improved time-to-result for the sniff

Related issues/external references

Fixes #

Types of changes

• [ ] Bug fix (non-breaking change which fixes an issue)
• [ ] New feature (non-breaking change which adds functionality)
• [ ] Breaking change (fix or feature that would cause existing functionality to change)
  • [ ] This change is only breaking for integrators, not for external standards or end-users.
• [ ] Documentation improvement

[jrfnl]

Closing as replaced by https://github.com/PHPCSStandards/PHP_CodeSniffer/pull/64