Generic/OpeningFunctionBrace*: check spacing before brace for empty functions

[jrfnl]

Description

Basically this is the same fix for both sniffs. The sniffs would return, instead of skip over a particular check, which meant that other checks after the check which needed to be skipped were not being run.

Generic/OpeningFunctionBraceKernighanRitchie: check spacing before brace for empty functions

As things were, when an empty function was detected, the sniff would bow out and not execute the "SpaceBeforeBrace" check.

Fixed now.

Includes tests.

Generic/OpeningFunctionBraceBsdAllman: check spacing before brace for empty functions

As things were, when an empty function was detected, the sniff would bow out and not execute the "BraceIndent" check.

Fixed now.

Includes tests.

Suggested changelog entry

• Generic/OpeningFunctionBraceKernighanRitchie: spacing before opening brace will now also be checked for empty functions
• Generic/OpeningFunctionBraceBsdAllman: brace indent will now also be checked for empty functions

Types of changes

• [x] Bug fix (non-breaking change which fixes an issue)
• [ ] New feature (non-breaking change which adds functionality)
• [ ] Breaking change (fix or feature that would cause existing functionality to change)
  • [ ] This change is only breaking for integrators, not for external standards or end-users.
• [ ] Documentation improvement

[jrfnl]

Closing as replaced by https://github.com/PHPCSStandards/PHP_CodeSniffer/pull/80

[jrfnl]

FYI: this fix is included in today's PHP_CodeSniffer 3.8.0 release.

As per #3932, development on PHP_CodeSniffer will continue in the PHPCSStandards/PHP_CodeSniffer repository. If you want to stay informed, you may want to start "watching" that repo (or watching releases from that repo).