squizlabs / PHP_CodeSniffer

PHP_CodeSniffer tokenizes PHP files and detects violations of a defined set of coding standards.
BSD 3-Clause "New" or "Revised" License
10.66k stars 1.48k forks source link

Tokenizer::$eolChar: change default value #3870

Closed jrfnl closed 9 months ago

jrfnl commented 1 year ago

Description

Tokenizer::$eolChar: change default value to be a more logical one. The property is supposed to be a string, so having an array as a default value is confusing.

Suggested changelog entry

N/A

Types of changes

DannyvdSluijs commented 1 year ago

Given my "approval" based on the description of the PR and the discussion about a default EOL character which all made sense.

jrfnl commented 9 months ago

Closing as replaced by https://github.com/PHPCSStandards/PHP_CodeSniffer/pull/81