squizlabs / PHP_CodeSniffer

PHP_CodeSniffer tokenizes PHP files and detects violations of a defined set of coding standards.
BSD 3-Clause "New" or "Revised" License
10.66k stars 1.48k forks source link

Correct pluralization of the word space/spaces depending on the spacing value #3881

Closed DannyvdSluijs closed 8 months ago

DannyvdSluijs commented 1 year ago

This PR fixes more occurences of the word space(s) to be either space or spaces depending on the spacing value.

Description

This PR has been created after some brief discussion with @jrfnl in #3647 and addressing the Sniff I've pointed out in https://github.com/squizlabs/PHP_CodeSniffer/pull/3647#pullrequestreview-1593431719

Suggested changelog entry

Correct pluralization of the word space/spaces depending on the spacing value

Related issues/external references

Fixes #

Types of changes

PR checklist

jrfnl commented 8 months ago

@DannyvdSluijs Could you please re-pull this PR (with a reference to this one) in the https://github.com/PHPCSStandards/PHP_CodeSniffer repo ? I'd like to try and include it in the 3.8.0 release.

DannyvdSluijs commented 8 months ago

I’ll try and see if I can manage tonight. If not it should be somewhere this week. Thanks for the proactive stand and carrying through with PHPCS despite the hard times.

If you think I can be of help in any other way feel free to tag me in an issue or PR. And I’ll see what I can do to help.

DannyvdSluijs commented 8 months ago

This has been reopened in the continuation repository. See https://github.com/PHPCSStandards/PHP_CodeSniffer/pull/128