Config::processLongArgument(): fix storing of unknown arguments

jrfnl commented 8 months ago

Description

These arguments should be stored in the unknown property. There is no values property.

Note: the read/write logic is to prevent a Indirect modification of overloaded property PHP_CodeSniffer\Config::$unknown has no effect PHP notice.

Suggested changelog entry

N/A (I don't think this bug had any impact on end-users)

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] This change is only breaking for integrators, not for external standards or end-users.
[ ] Documentation improvement

jrfnl commented 7 months ago

Closing as replaced by https://github.com/PHPCSStandards/PHP_CodeSniffer/pull/97

jrfnl commented 7 months ago

FYI: this fix is included in today's PHP_CodeSniffer 3.8.0 release.

As per #3932, development on PHP_CodeSniffer will continue in the PHPCSStandards/PHP_CodeSniffer repository. If you want to stay informed, you may want to start "watching" that repo (or watching releases from that repo).

squizlabs / PHP_CodeSniffer