weierophinney
commented
8 months ago Sharing opinion is important and valuable
When the opinion you're sharing is "I don't see the need for this tool" or "I like a different tool", it's not helping anybody. The folks developing this tool and using it clearly find a need for it, and have a stated preference for using it (either personal, or as required by a project or org they work on or for).
phpcs pre-dates php-cs-fixer by more than a decade. Additionally, the two have very different mechanisms for extension, sharing extensions, and how they operate. php-cs-fixer grew from the Symfony ecosystem, focuses on the standards of that ecosystem, and is highly optimized towards fixing CS issues; if it can't fix it, the rule cannot be used. phpcs splits identifying and fixing issues as responsibilities, recognizing that some issues cannot be automatically fixed, but may need somebody to intervene - whether that's through refactoring, or skipping a rule at that location. This ability allows creation of tools like phpcompat.
Personally, I've preferred phpcs to php-cs-fixer as I've found it easier to configure and easier to share rules. I will NOT, however, say it's objectively worse or better - they're just different.
There's room for more than one approach here. Saying otherwise is discounting entire communities of developers.
javaDeveloperKid
Potherca
jrfnl
Neustradamus
mbomb007
TL;DR: This repo is being abandoned. The project continues in the PHPCSStandards organisation.
Okay, it's time.
About seven months ago, I was given commit access to this repository. At that time, @gsherwood and me had a call and the agreement was that we'd work together through the back log and get 3.8.0 released, which would give me the chance to get insight into his process, the release process and to verify that we were aligned in vision for the future for the repository. This agreement included, at my insistence, the provision that I would not merge my own PRs and that Greg would preferably also work via PRs for his contributions.
This started off well and I made a plan with a priority-list for which PRs to merge in which order, made lists with on-going and future projects etc and we had two calls in May this year, but I think most of you who have followed the repo closely will have noticed that it ended there.
I'd been trying to get a response, any kind of response, from Greg since beginning of June and have been sending pings at regular intervals with little effect, aside from one short "sorry, no sight on availability" in July.
A few of weeks ago, I have finally received a, just as short, response which basically said that Greg will abandon the project.
I very much respect Greg's decision and would like to thank him for all his tireless work and the years and years he has maintained this package for the benefit of the wider PHP community. He is a true open source hero and I wish him all the best.
Having said that, this is where we are now:
With that in mind, I asked Greg to transfer the repository to the PHPCSStandards organisation, which would give me full control. I also asked him to give me access to Packagist and PEAR. This would allow for keeping the package in PEAR and Packagist under its current name and should make for a smooth transition for end-users.
Unfortunately, Greg came back to me a week later and conveyed that the Squizlabs company has declined to transfer the repository stating "code ownership" as the reason.
Well, so be it. :shrug:
I have now forked the repo to the PHPCSStandards organisation, and spend some time to get it up & running properly
and I have registered the repo under the name. Update: The Composer/Packagist name will stay the same.phpcsstandards/php_codesnifferon PackagistThis is less than ideal as all of the 200.000+ packages which have a dependency on PHP_CodeSniffer will need to update their workflow/
composer.jsonSo here we are.
For the time being (for as long as I am the sole maintainer), I will merge my own PRs and I will work on getting 3.8.0 released as soon as possible. As I don't have access to PEAR, nor insight in how to release to PEAR, it will mean dropping support for installations via PEAR straight away. (note: this does not affect the PEAR sniffs) Support for installation via Composer, PHIVE, PHAR downloads and git clones will continue, though will all undergo name/address changes.
It also means that version 4.0 will be released sooner rather than later and that I will automate as much as possible of the release process to allow for more rapid releases.
Going forward, there are plenty of things I would like to improve, both to enhance the end-user experience, as well as to enhance the dev experience for maintainers of external standards. I also have a list of things in mind to try and make the repo more maintainable and make contributing more straight forward.
I have far more ideas than I have time, so I will need help and more importantly, the project will need significant funding, as the amount of work I see ahead of me would leave very little time for paid work, especially considering I also maintain a fair number of the external standards build on top of PHP_CodeSniffer.
I am posting this here in the spirit of openness and I am hopeful that you all will support me in this, both with quality contributions as well as by getting your employers/all those companies which use PHP_CodeSniffer to fund continued maintenance of the project.
Once the dust settles, I will announce more detailed plans for the future and a roadmap for future releases.
In the mean time, please bear with me. I currently still have quite a few other outstanding commitments, so it will take some time before I can free myself up sufficiently, but the repo is open for issues and PRs.
Please note: funding for this project is not a suggestion, but a requirement to safeguard the future of this project and allow for growing the maintainer pool. Without funding, I will not be able to dedicate the time needed to the project, both to move it forward, as well as to coach others to become co-maintainers. If you want to help, here are channels through which this project can receive funds:
If you support me in this, you can indicate this via a :+1: and by getting companies using PHP_CodeSniffer to start funding the project.
If you have any concerns about all this, please raise them by leaving a comment.
And if you have suggestions on how to make the switch-over experience smoother for end-users, please open an issue in the new repo.
Other than that, please join me in thanking @gsherwood for all the years he's kept this project going!
Oh and give @PHP_CodeSniffer on X or @phpcs on Mastodon a follow if you'd like to stay informed.
P.S.: In the interest of transparency, I have so far only merged maintenance related PRs in the new repo. Now this announcement is out, I will start merging functional PRs over the next few days or so.
/cc @kukulich @wimg @weierophinney @GaryJones @dingo-d @klausi @photodude @Potherca @webimpress @fredden @michalbundyra @sirbrillig @othercorey @greg0ire @dereuromark @umherirrender @stronk7 @Ocramius