search

squti / Android-Wave-Recorder

A powerful and efficient library to record WAVE form audio files (WAV) in Android
MIT License
239 stars 44 forks source link

Add skipSilence feature #12

Closed abkoradiya closed 3 years ago

abkoradiya commented 3 years ago

Hey, I have implemented the skip silence feature #8 . Review it and merge if it becomes helpful.

squti commented 3 years ago

Thanks for implementing this feature. I will test and review it asap.

squti commented 3 years ago

@abkoradiya Thanks for implementing this important feature. Your code seems clean and clever. There are just some ambiguous parts. I will appreciate it if you explain the mentioned parts.

abkoradiya commented 3 years ago

@abkoradiya Thanks for implementing this important feature. Your code seems clean and clever. There are just some ambiguous parts. I will appreciate it if you explain the mentioned parts.

which parts?

abkoradiya commented 3 years ago

@squti I have done changes. But I don't know how to merge two commits into one.

abkoradiya commented 3 years ago

I have tried to merge two commits. check it.

squti commented 3 years ago

Thanks for your changes. I've tried to test it with the sample app but it didn't work. I've used the default wave config and just set the skipSilence property true. Should I change something else?

abkoradiya commented 3 years ago

Thanks for your changes. I've tried to test it with the sample app but it didn't work. I've used the default wave config and just set the skipSilence property true. Should I change something else?

Don't know but it is working for me with just waveRecorder.skipSilence = true.