search

squti / Android-Wave-Recorder

A powerful and efficient library to record WAVE form audio files (WAV) in Android
MIT License
239 stars 44 forks source link

Not working with minSdk 30+ #6

Closed robertlevonyan closed 2 months ago

robertlevonyan commented 3 years ago

The lib is not working with Scoped Storage API

squti commented 3 years ago

I will check this.

robertlevonyan commented 3 years ago

Any news?

squti commented 3 years ago

@abkoradiya Could you fix this?

abkoradiya commented 3 years ago

@robertlevonyan what issue you are facing?

robertlevonyan commented 3 years ago

File API is not working on Android Q+ and if target API is 30. There is a new API called scoped storage.

abkoradiya commented 3 years ago

File API is not working on Android Q+ and if target API is 30. There is a new API called scoped storage.

yes we can change it using filedesriptor. till then you can use app directory using getFilesDir().

robertlevonyan commented 3 years ago

You also have RandomAccessFile. It is also should be changed

robertlevonyan commented 3 years ago

any news on this?

abkoradiya commented 3 years ago

any news on this?

I have created pull request. But I don't have time right now to do review changes.

robertlevonyan commented 3 years ago

I think you just need to merge PR and make a release, if you have already tested it :)

abkoradiya commented 3 years ago

I think you just need to merge PR and make a release, if you have already tested it :)

I have already tested it. it is working. but changes are remaining which are suggested by you.

squti commented 3 years ago

Yes it works but unfortunately the code is not clean so I had to reject PR.

squti commented 2 months ago

Commit 1b78f8b4dcb1788927c01bb1710e8b2377ee1e28 resolves this issue.