search

sqville / sqv

qooxdoo themes and more for qx.Desktop
MIT License
11 stars 1 forks source link

dangling comma #1

Closed jpriebe closed 5 years ago

jpriebe commented 6 years ago

When I ran generate.py, I got the following error:

Illegal dangling comma in map (pos (397, 4)) File: /Users/priebe/git/diesel/source/diesel/pubtools2/qooxdoo-5.0.1-sdk/application/sqv/source/class/sqv/theme/clean/Image.js

Fixed it by removing this comma in Image.js:

            "html" : {
              "border-radius": ".0625em",
            },
sqville commented 6 years ago

Hi Jason and thanks for the note!

Was it on the "fileicon-dy" entry within the CSSICONS object? I just searched my code, and i'm not seeing the same thing. Plus i've been away from this project for a while so no telling where i left off on all this :-)

sqville commented 6 years ago

Jason, I see what I did now. A few months back I decided to fork qooxdoo, and make clean a "real theme." I split out the theme from my little demo theme app, and left a lot undone in this repo. The latest theme without my controls (Diagram and Upload) is in my sqville-qooxdoo fork, clean_theme_v01 branch. Apologies for that, and thanks again for the note.

jpriebe commented 6 years ago

Thanks for taking at look at this! I'll try the clean_theme_v01 code. I'm excited to put a new "paint job" on a very old qooxdoo app (12 years and going strong!)

On Sat, Oct 27, 2018 at 12:39 PM sqville notifications@github.com wrote:

Jason, I see what I did now. A few months back I decided to fork qooxdoo, and make clean a "real theme." I split out the theme from my little demo theme app, and left a lot undone in this repo. The latest theme without my controls (Diagram and Upload) is in my sqville-qooxdoo fork, clean_theme_v01 branch. Apologies for that, and thanks again for the note.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/sqville/sqv/issues/1#issuecomment-433635786, or mute the thread https://github.com/notifications/unsubscribe-auth/ACniyBy2IUAxD7Xjh5YPwlFK6ZA7vM5Uks5upIxZgaJpZM4Xxacd .

jpriebe commented 6 years ago

OK -- I see what you're doing with the Clean theme, but I'm not sure how I would use it until it is accepted into the main qooxdoo repo. I could pull down your fork, but if the theme never gets added to the main repo, I will have to manually port your theme to newer qooxdoo versions, right?

Maybe I'm missing something, but it doesn't seem like the theme system lends itself to a nice standalone theme package that can be easily added to a qooxdoo-based app.

On Wed, Nov 7, 2018 at 4:26 PM Jason Priebe jason.priebe@gmail.com wrote:

Thanks for taking at look at this! I'll try the clean_theme_v01 code. I'm excited to put a new "paint job" on a very old qooxdoo app (12 years and going strong!)

On Sat, Oct 27, 2018 at 12:39 PM sqville notifications@github.com wrote:

Jason, I see what I did now. A few months back I decided to fork qooxdoo, and make clean a "real theme." I split out the theme from my little demo theme app, and left a lot undone in this repo. The latest theme without my controls (Diagram and Upload) is in my sqville-qooxdoo fork, clean_theme_v01 branch. Apologies for that, and thanks again for the note.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/sqville/sqv/issues/1#issuecomment-433635786, or mute the thread https://github.com/notifications/unsubscribe-auth/ACniyBy2IUAxD7Xjh5YPwlFK6ZA7vM5Uks5upIxZgaJpZM4Xxacd .

sqville commented 6 years ago

I wish I was better at the Devops/builds side of life Jason, because then I would have a definitive, almost condescending sounding answer for you ;-) What i do have is a thought. What if you fork qooxdoo (like i have), merge sqville/qooxdoo -master, then, going forward, merge both qooxdoo/qooxdoo AND my forked master into your fork? I've done this across branches. Not sure if it would work across repos. If this is a real thing then it should take care of you until I get my act together. What do you think?

jpriebe commented 6 years ago

That might work. But I will be honest, I have built a pretty solid proof of concept with the sqv theme that I originally downloaded. And that's quite a bit more modular, so I may stick with that. Laziness being a virtue and all... :-)

On Fri, Nov 9, 2018, 9:19 AM sqville <notifications@github.com wrote:

I wish I was better at the Devops/builds side of life Jason, because then I would have a definitive, almost condescending sounding answer for you ;-) What i do have is a thought. What if you fork qooxdoo (like i have), merge sqville/qooxdoo -master, then, going forward, merge both qooxdoo/qooxdoo AND my forked master into your fork? I've done this across branches. Not sure if it would work across repos. If this is a real thing then it should take care of you until I get my act together. What do you think?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/sqville/sqv/issues/1#issuecomment-437373005, or mute the thread https://github.com/notifications/unsubscribe-auth/ACniyI-oHD192D-Oy8Zb0eXPu3UQtxX1ks5utY8MgaJpZM4Xxacd .

sqville commented 5 years ago

Hey Jason,

I just made some massive updates to my theme: http://sqville.com/examples/widgetbrowser2018/index.html It's all sitting in my forked version of qooxdoo. I'll be submitting the PR to the group this week. Not sure how long it's going to take to get it there, but happy to help you tee up a version for your app if needed. Just let me know.

jpriebe commented 5 years ago

Sweet! I'm dozens of hours into reskinning our app (the new theme uses much larger geometries, so even our best-designed interfaces need a lot of reworking, and some of our worst ones had lots of hard-coded geometries, and have to be rebuilt). I'm excited that you've submitted a pull request. Our app looks so much fresher with your theme; I hope they'll accept the PR, and that it will help with qooxdoo adoption.

When I finish this work, I will give your theme a shot. Thanks for all the hard work I know you've put into this theme!

On Mon, Dec 10, 2018 at 7:13 PM sqville notifications@github.com wrote:

Hey Jason,

I just made some massive updates to my theme: http://sqville.com/examples/widgetbrowser2018/index.html It's all sitting in my forked version of qooxdoo. I'll be submitting the PR to the group this week. Not sure how long it's going to take to get it there, but happy to help you tee up a version for your app if needed. Just let me know.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/sqville/sqv/issues/1#issuecomment-446024014, or mute the thread https://github.com/notifications/unsubscribe-auth/ACniyB3tu_2Dp5THZMMlADIpPDXR0lCsks5u3vi9gaJpZM4Xxacd .

sqville commented 5 years ago

That resizing is a bear! I helped Tartan Solutions redesign their cloud product and, no joke, the majority of my time was spent ripping out Canvas layouts and replacing with VBox and HBoxes. They too were sucked in by the awesomness that was the Canvas layout, back in the day :-)

Update on the PR. The core team doesn't want to take responsibility for the theme. I don't blame them. My theme, on the surface, looks complex. But, in reality, it isn't. Everything I put in there follows tenants set forth by the framework itself. If I chopped up this one big PR into little PRs, asking for property and state additions here and there, then they would all probably go through without too much fuss.

Anyway, I'm not complaining. No one likes extra work and responsibility dropped on them by people with good intentions. It's like getting a puppy as a gift when you didn't want one. I'll keep you posted on the contrib.

Last thing. When you get a sec, take a look at your app(s) then take a look at semantic-ui.com (for inspiration). Then let me know your top 3 - 5 controls that you would like variations of. CheckBox is an example. Qooxdoo has one. Semantic UI has two, the standard checkbox and the one that looks like a slider. If I had more real world use cases then my time spent would be that much more focused and beneficial to everyone. :-)

jpriebe commented 5 years ago

I also went with VBox and HBox. Especially once I started following the Bootstrap UI convention of putting field labels above the field instead of next to the field, it just made more sense to flow the UI down the screen. Plus, it has the awesome benefit of reflowing when you set visibility to "excluded" on a control. I was able to remove large numbers of fixed height and width specifiers, which will presumably help code maintenance.

I don't know if I specifically need any alternate versions of controls, but I can tell you where I've run into some trouble.

Forgive me if (a) you've already fixed these or (b) the problems I had were due to interference between sqv/clean/*.js and my app's theme files (I have some custom controls, so I had to carry over my theme files to the newly skinned version of the app, making adjustments as I worked my way through the app's UI). So these issues may or may not apply to a "pure" sqv/clean app implementation. I'm a complete hack when it comes to the themes. I know qooxdoo pretty well (been building apps in it for 13 years), but I barely understand how the themes work.

I think rather than going overboard with alternate versions of controls, maybe you spend your time working on the packaging / documentation / etc. to make implementation as painless as possible (of course, if you have time to do both things, go for it!). Get some momentum behind your theme -- I think it will be very well received by qx developers. Maybe there will be enough pressure that the team incorporates your theme officially.

On Fri, Dec 14, 2018 at 1:39 AM sqville notifications@github.com wrote:

That resizing is a bear! I helped Tartan Solutions redesign their cloud product and, no joke, the majority of my time was spent ripping out Canvas layouts and replacing with VBox and HBoxes. They too were sucked in by the awesomness that was the Canvas layout, back in the day :-)

Update on the PR. The core team doesn't want to take responsibility for the theme. I don't blame them. My theme, on the surface, looks complex. But, in reality, it isn't. Everything I put in there follows tenants set forth by the framework itself. If I chopped up this one big PR into little PRs, asking for property and state additions here and there, then they would all probably go through without too much fuss.

Anyway, I'm not complaining. No one likes extra work and responsibility dropped on them by people with good intentions. It's like getting a puppy as a gift when you didn't want one. I'll keep you posted on the contrib.

Last thing. When you get a sec, take a look at your app(s) then take a look at semantic-ui.com (for inspiration). Then let me know your top 3 - 5 controls that you would like variations of. CheckBox is an example. Qooxdoo has one. Semantic UI has two, the standard checkbox and the one that looks like a slider. If I had more real world use cases then my time spent would be that much more focused and beneficial to everyone. :-)

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/sqville/sqv/issues/1#issuecomment-447230678, or mute the thread https://github.com/notifications/unsubscribe-auth/ACniyLeeoXdbYVeSKLpxxA4u0MXKK4SBks5u40e2gaJpZM4Xxacd .

sqville commented 5 years ago

Sounds like you and I had the exact same experience. I'm about to try my hand at using the Flow layout as the basis for single source app (one code base for all screens and devices). I'll let you know how that goes. :-)

I really appreciate you sharing your insight Jason! Super helpful!

Happy holidays and thanks again!

jpriebe commented 5 years ago

I may have found a little glitch in the menubutton icons.

I set a 24x24 icon on a menubutton. I noticed things looked a little strange, and when I inspected the DOM, that element was an tag with a src value and a backgroundImage. So it was doubling up my images.

I modified the menu-button/icon appearance in my app's theme to override your 18x18 icons with 24x24, and I set scale=false. That seems to have fixed the problem. Now I get a

with a background image.

At first I thought that maybe using high-res images (@2x) was to blame, but I don't think that's the issue. I think it's the scale=true setting in menu-button/icon. Maybe you can have a look at that.

On Fri, Dec 14, 2018 at 10:14 AM sqville notifications@github.com wrote:

Sounds like you and I had the exact same experience. I'm about to try my hand at using the Flow layout as the basis for single source app (one code base for all screens and devices). I'll let you know how that goes. :-)

I really appreciate you sharing your insight Jason! Super helpful!

  • Table - This guy is a bear to theme too. As a matter of fact it's more coding than themeing because you have to create your own Cell and Row renderer classes in order to get the precision you want/need. This is on my to-do list to rein in.
  • Subtle Colors - I completely agree with you on this. I did darken a bit, but it needs more. I will put more time into this for sure.
  • Icons - Fonts, I am defaulting to the framework team. They have a competing implementation that gets to the same result. I will revisit if/when necessary. SVG, embedding SVG into code is a must, and becoming common practice among frameworks. Pure CSS Icons, after HTML, nothing is more native than CSS. If done correctly, and creatively, it could be a significant "differentiator", and bring some notoriety. So "worth a try" in my book :-)

Happy holidays and thanks again!

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/sqville/sqv/issues/1#issuecomment-447354503, or mute the thread https://github.com/notifications/unsubscribe-auth/ACniyL80wfVFYxLiz4fBs9Y6ZxcNFneXks5u48BCgaJpZM4Xxacd .

sqville commented 5 years ago

Hmm. That looks to be carry over from some testing i was doing a long time back. I say that because the only inappropriate place i have scale=true in my latest and greatest repo is on my "primary-button/icon" appearance entry. I say "inappropriate place" because i do hard code sizes with scale for my SVG icons like tree folder and tree file. And my CSS icons like checkbox/icon. All others I've reverted back to the original qx way of handling "appearance-entry"/icon.

Anyway, sounds like you fixed it perfectly - setting scale back to false. Setting scale to true does flip the object's mode, thus changing the tag from div to image.

sqville commented 5 years ago

Jason, I just updated my sqv repo with the updates from the PR i sent to the qx team. This should have all the fixes I've done to date.

sqville commented 5 years ago

O, and do you mind if i close this issue? You can always open an new issue or email me directly - chris.eskew@sqville.com