search

sqweek / dialog

Simple cross-platform dialog API for go-lang
ISC License
493 stars 76 forks source link

Add Go dependency management #13

Closed crazy-max closed 5 years ago

sqweek commented 6 years ago

Hiya! Sorry for the late reply, I was on vacation last week. Did you do the work to add dependencies in response to a problem? eg. I see you're requesting a specific version of mattn/go-gtk - is dialog not working with newer/older versions?

I'm not overly fond of the first commit; I don't think I've ever used an editor which supports .editorconfig before, and IMO editor-specific ignores don't belong in the main repo. Note that you can add these patterns to .git/info/exclude in your own checkout to ignore them without having to commit a .gitignore.

crazy-max commented 6 years ago

Hey @sqweek,

You right about gitignore it's an idiommatism in my projects :smile: but concerning editorconfig i think it's useful to preserve coding style and consistency. Editorconfig covers a wide range of IDE / text editors if you want to take a look. Anyway i have reverted this change.

Secondly, regarding the need for a dependency manager, I think it is useful if not necessary to integrate one into your project in order to know the revisions of the dependencies used. Whether for debugging or consistency.

crazy-max commented 5 years ago

Hi @sqweek,

I have made some changes to use the official go modules to resolve dependencies.

sqweek commented 5 years ago

Hey @crazy-max, thanks for your work and patience on this issue. The latest changes look good - I've made a small tweak which you can see in 02eff94385065aba0b1108eac3cee8f7c716d1e7 ¹ and squashed the whole branch down to one commit, which looks like this: a416fa4b6783024418b0828ce9e68c536b07f7f1

¹ I changed "crazy-max/dialog" to "sqweek/dialog" in go.mod, and committed go.sum to the repo based on this tweet

If you're happy with my changes to your commit I'll go ahead and push it to the master branch. I notice your commits are labelled with the address crazy-max@users.noreply.github.com, is that how you want it to be or is there a different email address you would prefer to publish?

crazy-max commented 5 years ago

Yep indeed I've forgot the checksum file. Everything LGTM and you can keep this email thx!

sqweek commented 5 years ago

Done! Thanks again :)