search

sqweek / dialog

Simple cross-platform dialog API for go-lang
ISC License
493 stars 76 forks source link

Add missing StartDir builder func #2

Closed patrickgh3 closed 6 years ago

patrickgh3 commented 6 years ago

Tiniest pull request. Thanks for the useful package!

sqweek commented 6 years ago

Glad you find it useful :) Sorry for the delay, it's been a busy week! The patch looks good functionally but the comment about windows is inappropriate -- for one this is a cross-platform package, and for two "windows style path" is a vague term. Does it need to contain backslashes? Or does it need a drive letter?

I know I'm being picky over such a small change but if it's the former (backslashes required) I consider it a bug, as the same path would work elsewhere in go.

patrickgh3 commented 6 years ago

Whoops! You're totally right. I just removed that part of the comment to keep it simple.

sqweek commented 6 years ago

Thanks, squashed & landed. Also opened issue #3 since this PR reminded me that I never got around to the OSX implementation ;)