search

sqweek / dialog

Simple cross-platform dialog API for go-lang
ISC License
493 stars 76 forks source link

Implements Ok Message Dialog #6

Closed juliardi closed 6 years ago

juliardi commented 6 years ago

Implements Ok Message Dialog for Linux, Windows, and OSX

juliardi commented 6 years ago

Please review the code. Also I can only test for Linux parts, so please especially review and test the Windows and OSX parts.

sqweek commented 6 years ago

Thanks for your work! The PR looks good and works as expected on windows. Just a couple of minor things to address, which I'm happy to do myself if you're out of time but I'm about to get on a plane and have a busy weekend coming up so it might be a few days :)

juliardi commented 6 years ago

Thanks for the review. I've commited some minor change including the "Information" icon for OSX. Please review them when you have time for it. :)

sqweek commented 6 years ago

@juliardi Thanks again! I've merged this with some minor changes:

  1. I split the formatting changes into their own commit
  2. I renamed the spawning function from Ok() to Info()