search

sqweek / dialog

Simple cross-platform dialog API for go-lang
ISC License
493 stars 76 forks source link

Macos build errors #69

Closed hismailbulut closed 1 year ago

hismailbulut commented 1 year ago

When building with github runner this error is generated

Error: ../../../go/pkg/mod/github.com/sqweek/dialog@v0.0.0-202207291647[23](https://github.com/hismailbulut/Neoray/runs/7714948517?check_suite_focus=true#step:6:24)-0e168706f490/cocoa/dlg_darwin.go:67:56: too many arguments in call to fileDlg
    have (int, string, []string, bool, string, string)
    want (int, string, []string, bool, string)
Error: ../../../go/pkg/mod/github.com/sqweek/dialog@v0.0.0-20220729164723-0e168706f490/cocoa/dlg_darwin.go:71:56: too many arguments in call to fileDlg
    have (number, string, nil, bool, string, string)
    want (int, string, []string, bool, string)
Error: ../../../go/pkg/mod/github.com/sqweek/dialog@v0.0.0-20220729164723-0e168706f490/cocoa/dlg_darwin.go:90:5: undefined: filename
Error: ../../../go/pkg/mod/github.com/sqweek/dialog@v0.0.0-20220729164723-0e168706f490/cocoa/dlg_darwin.go:91:[26](https://github.com/hismailbulut/Neoray/runs/7714948517?check_suite_focus=true#step:6:27): undefined: filename
hismailbulut commented 1 year ago

It seems related to 0e168706f490493fd445a79375d8d139d01ab59d

sqweek commented 1 year ago

Yep I messed up the merge. Thanks for letting me know!