search

sqweek / dialog

Simple cross-platform dialog API for go-lang
ISC License
493 stars 76 forks source link

Fix deprecated warnings for macOS #82

Open karelbilek opened 4 months ago

karelbilek commented 4 months ago

macOS has a new framework UniformTypeIdentifiers that needs to be used for this.

Note that the behavior is not exactly the same - if you add "jpg", it will find a UTType that has "jpg" extension and will use that instead of creating a new type; so it will match both "jpg" and "jpeg".

I think it is acceptable (and, probably, even better).

karelbilek commented 4 months ago

It's the correct fix of #73 (#73 doesn't actually work).

I haven't done any Obj-C in a long time, I hope it's all correct :P

sqweek commented 4 months ago

I like the sound of it, my only reservation based on the docs is this:

ie. adopting UTType would drop support for 11 years worth of operating systems. Of course we can stay on the deprecated API forever, but suddenly requiring everyone to be within 4 years of bleeding-edge seems a bit too harsh a jump.

Hmm, although this is a little bit exaggerated because 11.0 does support older machines, even some laptops back to 2013. Within 10 years of bleeding-edge seems like an OK cutoff... let me sleep on it

karelbilek commented 4 months ago

I am not sure how much does golang even support older macos-es.

would need to look it up

On Mon 26. 2. 2024 at 15:16, sqweek @.***> wrote:

I like the sound of it, my only reservation based on the docs https://developer.apple.com/documentation/uniformtypeidentifiers/uttype/3548216-typewithfilenameextension is this:

  • macOS 10.6 release date: 28 August 2009
  • macOS 11.0 release date: 12 November 2020

ie. adopting UTType would drop support for 11 years worth of operating systems. Of course we can stay on the deprecated API forever, but suddenly requiring everyone to be within 4 years of bleeding-edge seems a bit too harsh a jump.

Hmm, although this is a little bit exaggerated because 11.0 does support older machines, even some laptops back to 2013. Within 10 years of bleeding-edge seems like an OK cutoff... let me sleep on it

— Reply to this email directly, view it on GitHub https://github.com/sqweek/dialog/pull/82#issuecomment-1964250120, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAZT4KTIVYMAORSULZX6WTYVSKM3AVCNFSM6AAAAABDPWNORCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNRUGI2TAMJSGA . You are receiving this because you authored the thread.Message ID: @.***>

karelbilek commented 4 months ago

see this and similar

https://github.com/golang/go/issues/57125

On Mon 26. 2. 2024 at 15:24, Karel Bílek @.***> wrote:

I am not sure how much does golang even support older macos-es.

would need to look it up

On Mon 26. 2. 2024 at 15:16, sqweek @.***> wrote:

I like the sound of it, my only reservation based on the docs https://developer.apple.com/documentation/uniformtypeidentifiers/uttype/3548216-typewithfilenameextension is this:

  • macOS 10.6 release date: 28 August 2009
  • macOS 11.0 release date: 12 November 2020

ie. adopting UTType would drop support for 11 years worth of operating systems. Of course we can stay on the deprecated API forever, but suddenly requiring everyone to be within 4 years of bleeding-edge seems a bit too harsh a jump.

Hmm, although this is a little bit exaggerated because 11.0 does support older machines, even some laptops back to 2013. Within 10 years of bleeding-edge seems like an OK cutoff... let me sleep on it

— Reply to this email directly, view it on GitHub https://github.com/sqweek/dialog/pull/82#issuecomment-1964250120, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAZT4KTIVYMAORSULZX6WTYVSKM3AVCNFSM6AAAAABDPWNORCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNRUGI2TAMJSGA . You are receiving this because you authored the thread.Message ID: @.***>

sqweek commented 4 months ago

Interesting read. I'm not in a rush to mandate a 6-month old go version either.

go 1.10 is only 6 years old and supported macOS 10.8 (it was the last go version with official support]).

karelbilek commented 4 months ago

okay. in that case, let's leave the deprecated warnings and close this ticket. it doesn't hurt anything. it's deprecated for a long time and they don't seem in a hurry to remove it.

just add a comment to that piece of code so someone doesn't open the same ticket again.

(not sure if the old go even builds this code but let's test that separately:))

On Mon 26. 2. 2024 at 16:46, sqweek @.***> wrote:

Interesting read. I'm not in a rush to mandate a 6-month old go version either.

go 1.10 is only 6 years old and supported macOS 10.8 (it was the last go version with official support https://github.com/golang/go/issues/23011 ]).

— Reply to this email directly, view it on GitHub https://github.com/sqweek/dialog/pull/82#issuecomment-1964461341, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAZT4IQLJTT2YQDSIPIARTYVSU5RAVCNFSM6AAAAABDPWNORCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNRUGQ3DCMZUGE . You are receiving this because you authored the thread.Message ID: @.***>