search

sramirez / spark-MDLP-discretization

Spark implementation of Fayyad's discretizer based on Minimum Description Length Principle (MDLP)
Apache License 2.0
44 stars 27 forks source link

Add some unit tests #3

Closed barrybecker4 closed 8 years ago

barrybecker4 commented 8 years ago

It would be nice to add some unit tests that would prove that it works as expected and act as documentation by way of examples. I will try to add some and do a PR.

barrybecker4 commented 8 years ago

I created a pull request: https://github.com/sramirez/spark-MDLP-discretization/pull/5

sramirez commented 8 years ago

I've just merged PR #5. Nice addition. maxBins bug is now fixed. I get erros in test 6, 7, 8, and 10. I've fixed test 2. I think in 6,7,8 there is a problem with number precision.

I think I'll also include the unit test that I've been using in my experiments, which consist of data from the paper associated to this project.

barrybecker4 commented 8 years ago

That would be great. Thanks.

barrybecker4 commented 8 years ago

Initial unit tests have been added. We can always add more as needed. Current tests are all passing. I will close this.