search

sramirez / spark-MDLP-discretization

Spark implementation of Fayyad's discretizer based on Minimum Description Length Principle (MDLP)
Apache License 2.0
44 stars 27 forks source link

Add jenkinsfile to enable CI building in jenkins #37

Open barrybecker4 opened 6 years ago

barrybecker4 commented 6 years ago

I would like to investigate creating a PR to add a jenkins file to allow for automated building if there is a jenkins server. The jenkins file will have no effect if there is no jenkins server.

sramirez commented 6 years ago

Sounds good. If this change won't affect non-jenkin server, go ahead.

barrybecker4 commented 6 years ago

@sramirez, I added the Jenkinsfile on our fork, but I'm not going to do a PR for it because it is fairly specific to our use. It does not effect any non-jenkins server. One question I have is, why do we need the pom.xml file checked in. It duplicates the version numbers that are already in sbt - so some of them are bound to get out of sync. When I deploy to a JFrog artifactory all the pom file is automatically generated. I think it should be removed from git to avoid confusion. Do you agree?

sramirez commented 6 years ago

@barrybecker4 Maybe I'm wrong, I'm not an expert in this matter. But some people don't use sbt, but maven (including me). I usually compile and package my project with maven, so maybe we can add a message to the README file giving some indications about what you said above. What do you think?