sraoss / pg_ivm

IVM (Incremental View Maintenance) implementation as a PostgreSQL extension
Other
862 stars 24 forks source link

Make create_immv STRICT #3

Closed marcocitus closed 2 years ago

marcocitus commented 2 years ago

This currently crashes the server: SELECT create_immv(NULL, 'SELECT * FROM test'); .

Marking the function STRICT will avoid calling it with NULL arguments. (not sure if you have a SQL upgrade script policy yet)

Alternative would be check for NULL in create_immv.

yugo-n commented 2 years ago

Thank you for pointing out it. Merged.

Although, it might be useful to raise en error after checking for NULL, I would like to use STRICT to avoid the crash for now.