Support exists_subquery

sraoss / pg_ivm

IVM (Incremental View Maintenance) implementation as a PostgreSQL extension

Other

990 stars 27 forks source link

Support exists_subquery #53

Closed thoshiai closed 1 year ago

thoshiai commented 1 year ago

Simple EXISTS clause is supported by this patch. A query is not supported when WHERE clause has OR-condition or JOIN-condition is not contained by targetlist.

yugo-n commented 1 year ago

I made some review comments. Especially, I think it would be nice if we have more comments in the code because we do somewhat complicated things for handling EXITS.

Also, could you please update README?

thoshiai commented 1 year ago

Thank you for your review. I fixed and add README messages

yugo-n commented 1 year ago

I found that the following view definition caused a segmentation fault.

select create_immv('xx2', 'select exists(select 1 from t) from t2 ');

Could you fix the query check to prevent this?

yugo-n commented 1 year ago

Thank you for adding the description that EXISTS subqueries are supported to README!

If I understand correctly, I wonder that it would better to add the following information:

EXISTS subquery is supported only in WHERE but not in the target list (Maybe, it is mandatory because it already explains Subqueries in targetlist are not supported, but adding the information would be helpful for clarification.)
Restriction that if EXISTS contains columns that refer to columns in tables in the outer query, such columns must be included in the target list.

thoshiai commented 1 year ago

fix segmentation fault and add README