search

sraoss / pgsql-ivm

IVM (Incremental View Maintenance) development for PostgreSQL
Other
129 stars 12 forks source link

Improve an error message for unspoorted aggregate functions #72

Closed yugo-n closed 4 years ago

yugo-n commented 4 years ago

Currentlly only built-in aggregate functions are supported, so aggregates on user-defined types causes an error at view definition time. However, the message was unappropreate like:

ERROR: aggregate function max is not supported

even though built-in max is supported. Therefore, this is improved to include its argument types as following:

ERROR: aggregate function min(xxx) is not supported HINT: IVM supports only built-in aggregate functions.

(Github issue #65)

thoshiai commented 4 years ago

It sounds good! I tested this patch a little, but it is fine.