search

srawlins / timezone

Time zone database and time zone aware DateTime object for Dart.
BSD 2-Clause "Simplified" License
102 stars 53 forks source link

Isolate support #147

Closed saibotma closed 1 month ago

saibotma commented 1 year ago

Steps to reproduce the issue:

→ You'll notice that they don't equal because their Locations do not equal. This PR overrides == and hashCode of Location, by assuming that two Locations are the same when their name is the same. I hope that this is sufficient, because additionally comparing transitionAt, transitionZone and zones would require using IterableEquality.equals which is not very performant.

I am happy to discuss any changes required to merge this thing asap.

SungHyun22 commented 1 year ago

Anything update?

saibotma commented 1 year ago

@srawlins Would be great if we could merge this. I had this in use in my production app for half a year now using a fork. Is there anything missing from your point of view?

saibotma commented 1 month ago

Is there anything i can do for this to be merged? @srawlins

srawlins commented 1 month ago

Sorry about the extreme delay. This looks good to me!