Closed saibotma closed 1 month ago
Anything update?
@srawlins Would be great if we could merge this. I had this in use in my production app for half a year now using a fork. Is there anything missing from your point of view?
Is there anything i can do for this to be merged? @srawlins
Sorry about the extreme delay. This looks good to me!
Steps to reproduce the issue:
→ You'll notice that they don't equal because their Locations do not equal. This PR overrides
==
andhashCode
ofLocation
, by assuming that two Locations are the same when their name is the same. I hope that this is sufficient, because additionally comparingtransitionAt
,transitionZone
andzones
would require usingIterableEquality.equals
which is not very performant.I am happy to discuss any changes required to merge this thing asap.