search

srawlins / timezone

Time zone database and time zone aware DateTime object for Dart.
BSD 2-Clause "Simplified" License
101 stars 52 forks source link

Fix incorrect DST transition #166

Closed Pante closed 3 months ago

Pante commented 1 year ago

This PR fixes #164.

While fixing the issue, I noticed that there's some slightly inconsistencies with how TzDateTimes that falls in the middle of an overlap are handled. For negative offsets, the earlier time is chosen, for positive offsets, the later time is chosen. I'm not sure whether this should be fixed since it might break backwards compatibility.

srawlins commented 1 year ago

Looks like you just need to run a quick dart format test/datetime_test.dart.

Pante commented 1 year ago

Whoops, fixed the formatting, @srawlins.

Pante commented 1 year ago

@srawlins any updates on this?