search

srawlins / timezone

Time zone database and time zone aware DateTime object for Dart.
BSD 2-Clause "Simplified" License
102 stars 54 forks source link

support the upcoming glob package #76

Closed jakemac53 closed 3 years ago

jakemac53 commented 3 years ago

Needs an override on the git branch for now, this is temporary for landing glob 2.0 internally as I will need to pull this in with the glob roll.

srawlins commented 3 years ago

Can you lay out the planned tasks here? Or comment on my guess, haha:

  1. land this
  2. import this into timezone internal
  3. land glob in SDK DEPS, import it into internal
  4. remove override in the timezone package?
  5. pub publish the timezone package?

I'm fuzzy on how/when I publish with this nullsafety version of glob as a dep.

jakemac53 commented 3 years ago

Your assumed plan was basically correct :)

  1. land this
  2. import this into timezone internal
  3. land glob in SDK DEPS, import it into internal
  1. Publish glob :)
  1. remove override in the timezone package?
  2. pub publish the timezone package?

I'm fuzzy on how/when I publish with this nullsafety version of glob as a dep.

You can publish at any time, once we have 2.12.0 stable we will publish a stable release, this is only a dev dependency anyways though.

jakemac53 commented 3 years ago

Actually ya you probably have no reason to even bother with publishing since it is only a dev dep

srawlins commented 3 years ago

Thanks much!