srbhr / Resume-Matcher

Resume Matcher is an open source, free tool to improve your resume. It works by using language models to compare and rank resumes with job descriptions.
https://www.resumematcher.fyi/
Apache License 2.0
4.92k stars 2.11k forks source link

Removed circular dependancy of qdrant-client #129

Closed sriramr244 closed 1 year ago

sriramr244 commented 1 year ago

Pull Request Title

Related Issue

Description

Type

Proposed Changes

Checklist

srbhr commented 1 year ago

Hey @sriramr244 I think you have added the RM package in this PR. Can you remove it?

sriramr244 commented 1 year ago

Oops sorry I will remove it. Its a venv

On Wed, Aug 30, 2023 at 10:32 AM Saurabh Rai @.***> wrote:

Hey @sriramr244 https://github.com/sriramr244 I think you have added the RM package in this PR. Can you remove it?

— Reply to this email directly, view it on GitHub https://github.com/srbhr/Resume-Matcher/pull/129#issuecomment-1699301661, or unsubscribe https://github.com/notifications/unsubscribe-auth/AMA3736EYR2VEBKZEC3BE53XX5FIHANCNFSM6AAAAAA4ETUYFA . You are receiving this because you were mentioned.Message ID: @.***>

srbhr commented 1 year ago

The thing is that adding qdrant-client in the requirements.txt installs version <1. Which doesn't contains the URL parameter. I think I need to add that into the README or some other file.