Move API keys and qdrant URL from config file to environment varibales. - Githubissues

srbhr / Resume-Matcher

Resume Matcher is an open source, free tool to improve your resume. It works by using language models to compare and rank resumes with job descriptions.

https://www.resumematcher.fyi/

Apache License 2.0

4.72k stars 1.86k forks source link

Move API keys and qdrant URL from config file to environment varibales. #139

Closed rizahmeds closed 10 months ago

rizahmeds commented 10 months ago

Issue Title

Place API KEY and URL as environment variable instead of in YAML config file.

Type

[ ] Big
[x] Feature Request
[ ] Info
[ ] Bug
[ ] Documentation
[ ] Other (please specify):

Description

Currently cohere and qdrant api keys are in a yaml config file.

Expected Behavior

Use .env file to store api keys and url as environment variables.

Current Behavior

config.yml(File) is in .gitignore so that Git should ignore this file. But that is not an appropriate way to handle it.

This is a sensitive data and user can accidentally commit this file.

Steps to Reproduce

Screenshots / Code Snippets (if applicable)

Environment

Operating System:
Browser (if applicable):
Version/Commit ID (if applicable):

Possible Solution (if you have any in mind)

We can use python-dotenv module to read environment variables from .env file.

Additional Information

srbhr commented 10 months ago

Hi @rizahmeds thanks for the Issue. Yes, we are sorting that feature out. And in the webapp there is a better way to handle those API keys.