fix: issue with [docker-compose up] command

srbhr / Resume-Matcher

Resume Matcher is an open source, free tool to improve your resume. It works by using language models to compare and rank resumes with job descriptions.

https://www.resumematcher.fyi/

Apache License 2.0

4.72k stars 1.86k forks source link

fix: issue with [docker-compose up] command #146

Open rizahmeds opened 10 months ago

rizahmeds commented 10 months ago

Pull Request Title

Fixed issue, while running command docker-compose up locally.

Related Issue

Fixes #144

Description

Type

[x] Bug Fix
[ ] Feature Enhancement
[ ] Documentation Update
[ ] Code Refactoring
[ ] Other (please specify):

Proposed Changes

Change python base-image from python:3.11.0-slim to python:3.11-slim-bullseye
Remove unnecessary RUNs

Screenshots / Code Snippets (if applicable)

How to Test

docker-compose up

Checklist

[x] The code compiles successfully without any errors or warnings
[x] The changes have been tested and verified
[ ] The documentation has been updated (if applicable)
[ ] The changes follow the project's coding guidelines and best practices
[x] The commit messages are descriptive and follow the project's guidelines
[ ] All tests (if applicable) pass successfully
[x] This pull request has been linked to the related issue (if applicable)

Additional Information

srbhr commented 10 months ago

Hi @rizahmeds I'll take a look at it. Thanks for the PR.

srbhr commented 9 months ago

Hi @rizahmeds I'm unable to get this running properly in my local. I'll ask in the discord for anyone to test it out.

rizahmeds commented 9 months ago

Hi @rizahmeds I'm unable to get this running properly in my local. I'll ask in the discord for anyone to test it out.

Alright @srbhr Thanks!

SubramanyamChalla24 commented 9 months ago

hi @rizahmeds , I was getting the below error when i test your code I think it is an issue with the python version. can you test from your end and verify if it working? are you able to get the similarity score when you are using the config file?

rizahmeds commented 9 months ago

Hi @SubramanyamChalla24, Thanks for pointing this out. This error is due to older version of QdrantClient which didn't had url parameter. Make sure you have qdrant-client>=1.2 in virtualenv or docker container. (Note: Please do pip list to check qdrant-client version installed)

@srbhr Now i am just wondering, why config.yml have been remove from scripts/similarity path, because we still reading the config file here in this line of code

SubramanyamChalla24 commented 9 months ago

Now i am just wondering, why config.yml have been remove from scripts/similarity path, because we still reading the config file here in this line of code

That is because the user needs to add the config file manually as it contains the private api keys.

rizahmeds commented 9 months ago

@SubramanyamChalla24 Make sense. Earlier we only needed to replace the values that's why I got confused 😅

SubramanyamChalla24 commented 9 months ago

This error is due to older version of QdrantClient which didn't had url parameter. Make sure you have qdrant-client>=1.2 in virtualenv or docker container. (Note: Please do pip list to check qdrant-client version installed)

I have the latest version. It's not an error with the version though. can you check from your side including the config file?

rizahmeds commented 9 months ago

Yes, i already checked with the config.yaml file. Since I do not have the cohere API key(Because it requires me to add a credit card detail, which I don't have 🥺), it raises another exception for me. So I can't completely test it.

SubramanyamChalla24 commented 9 months ago

Cohere doesn't require a credit card. Can you check it once?It required a card before but it doesn't need it now.

Yes, i already checked with the config.yaml file. Since I do not have the cohere API key(Because it requires me to add a credit card detail, which I don't have 🥺), it raises another exception for me. So I can't completely test it.

rizahmeds commented 9 months ago

Thanks for the update @SubramanyamChalla24. Yes i have got the Cohere Trial key. Then i reinitialized qdrant cluster which was suspended. Here you go, Finished getting similarity score.

srbhr commented 9 months ago

Great work in collaboration @rizahmeds and @SubramanyamChalla24 🔥 I like the teamwork here. So, is this PR working now?

SubramanyamChalla24 commented 9 months ago

So, is this PR working now?

I couldn't replicate it. It still shows the same error though. Probably someone has to try and verify it.