Footer section inclusion - Githubissues

srbhr / Resume-Matcher

Resume Matcher is an open source, free tool to improve your resume. It works by using language models to compare and rank resumes with job descriptions.

https://www.resumematcher.fyi/

Apache License 2.0

4.7k stars 1.85k forks source link

Footer section inclusion #212

Closed sandipkarmokar closed 8 months ago

sandipkarmokar commented 8 months ago

changes made:

Add footer section
Created a footerLinks.ts file which contains links and labels of footer items
added icons
fixed a bug where text whose colors werent explictly defined was showing black
minor issue where job description box wasnt rounded

sandipkarmokar commented 8 months ago

@Sayvai @srbhr please review it, thanks @Sayvai for guiding me🙏

sandipkarmokar commented 8 months ago

@Sayvai fixed changes as suggested by you and moved the social media icons to the right.

sandipkarmokar commented 8 months ago

@Sayvai fixed changes, also removed a redundant div which was part of the footer, since there is only one div with icons now. Directly added the styles to it

sandipkarmokar commented 8 months ago

@Sayvai thanks for the review🙏

srbhr commented 8 months ago

Nice teamwork @Sayvai and @sandipkarmokar, changes are good I'm merging your PRs.