search

src-d / blog

source{d} blog
https://blog.sourced.tech/
GNU General Public License v3.0
27 stars 41 forks source link

go-git v4 announcement #163

Closed campoy closed 6 years ago

campoy commented 6 years ago

Hey @mcuadros I need your help with the feature part

marnovo commented 6 years ago

@campoy @mcuadros @vmarkovtsev anything pending besides what's currently on the comments? ⏳🚢

campoy commented 6 years ago

I applied all of the feedback you mentioned, I think we're ready to publish.

campoy commented 6 years ago

@mcuadros, what do you think?

campoy commented 6 years ago

It seems all changes were approved but I still have no right to merge. Please do this so I can publish it tomorrow morning.

Thanks! @mcuadros

dpordomingo commented 6 years ago

As explained by guide/engineering/continuous-delivery Everytime something is merged, it must be tagged -» deployed That's what we agreed with @src-d/infrastructure in order to avoid deploying unexpected things when someone is deploying (other post, a bugfix, infra changes...) @campoy please tell me if this post is not published EOD in order to set it as draft and avoid unexpected problems.

vmarkovtsev commented 6 years ago

Can we revise these rules for the blog? The problem is that we cannot deploy a post using a smartphone for example - smartphones cannot tag commits. I doubt that the additional security is worth it. PRs already take weeks to merge, and the situation when two people merge at the same time is super rare - I have not seen any actually.

rporres commented 6 years ago

@vmarkovtsev Can't you create a release from a smartphone? That would create a tag in the repository...

vmarkovtsev commented 6 years ago

That will be a pain but I agree, seems that I can.

rporres commented 6 years ago

If we see that's too much of a pain in the near future and providing that the CD doesn't give us any grief, I'm totally happy to remove the need for a tag to deploy

dpordomingo commented 6 years ago

Tags can be created easily using the desktop view (available as a link at the footer at all GitHub pages) Anyhow, I'm ok with reviewing and changing the CD, to deploy on master merge instead of on tag. (I wonder if @campoy wanted to deploy on ES morning, or in SF morning)

campoy commented 6 years ago

The deploy time was a bit early, but thanks nonetheless!

What I would want is a way to schedule a publication, something similar to what medium does.

dpordomingo commented 6 years ago

You could do it with the article front matter date attribute, but since the contents are statically generated by Hugo, it's done at deploy time :(

(anyhow, I think you should have tag privileges, same as we: Vadim and I already have) You could maybe ask @mcuadros