add social cards - Githubissues

src-d / blog

source{d} blog

https://blog.sourced.tech/

GNU General Public License v3.0

27 stars 41 forks source link

add social cards #184

Closed campoy closed 6 years ago

campoy commented 6 years ago

Fixes #174

Signed-off-by: Francesc Campoy campoy@golang.org

campoy commented 6 years ago

Validated on:

facebook

twitter

google+

campoy commented 6 years ago

It looks great even on Slack!

dpordomingo commented 6 years ago

By the way, many thanks for attaching screenshots to the cards!!! it's really useful for changes with visual impact!

campoy commented 6 years ago

new version uploaded and being deployed to staging

campoy commented 6 years ago

since opengraph does not support SVG I asked @ricardobaeta to provide a png image for the links to listings (such as the homepage itself)

ricardobaeta commented 6 years ago

@campoy Here you go. Please be so kind to tell me if everything it's ok. I'm providing the biggest social asset resolution.

sourced tech

dpordomingo commented 6 years ago

@campoy I saw your last commit addressing my comments and it LGTM. Ping me once you've deployed it into staging, with the listings logo, and I'll do a final sanity check there :dagger:

campoy commented 6 years ago

Ready now! Somehow had to add https: for the twitter:image.

campoy commented 6 years ago

twitter:

facebook

for some reason it doesn't display correctly on google+ ... luckily not many use it

dpordomingo commented 6 years ago

Do you think that the (not blocker) problem with G+ can be related with the lack of http: in og:image and og:url ?

campoy commented 6 years ago

I tried adding it and it didn't fix it, I suspect it might be something related to the size of the image (when you share a link to a post it works correctly)