Closed ricardobaeta closed 5 years ago
@campoy @vmarkovtsev please provide feedback. As @ricardobaeta will be on holidays from next week on 3 weeks, I'll be the one getting the flak and making the edits. Thanks!
I am going to read this on Friday when I get my glasses. Please ping me if I do not post anything then.
Deal.
In the future, please follow the instructions on the issue template please 😄
Reviewing now
Also, you're creating this PR against staging? That's weird
Thank you Ricardo for many new idioms and enriching my vocabulary.
@ricardobaeta please check all the feedback. :)
I'll remove myself from the reviewer list as this is not that technical, but I'd like to have @vcoisne's opinion on this.
Was this ever published? If not, @vcoisne can you schedule it?
Scheduled for 11/15 @ricardobaeta
Hey @ricardobaeta, make sure you sign-off your latest commit too so the DCO bot doesn't complain.
Also you're gonna need to resolve the conflicts on authors.yml
Thanks!
And as Francesc mentioned you have to sign your commits and fix the conflicts on data/authors.yml
, @ricardobaeta.
Yes @marnovo I'll take care of this. The last commit was actually signed but I forgot the "<" & ">"
I deployed it into staging just in case you want to double check it :dagger: https://blog-staging.srcd.run/post/cheers-to-small-beginnings/
A blog post on a closer look at source{d}’s rebranding.