src-d / blog

source{d} blog
https://blog.sourced.tech/
GNU General Public License v3.0
27 stars 41 forks source link

commit yarn.lock for deterministic builds #252

Closed dreamalligator closed 5 years ago

dreamalligator commented 5 years ago

it is good practice to commit your yarn.lock file for deterministic builds.

see https://yarnpkg.com/lang/en/docs/yarn-lock/

hacktoberfest

vmarkovtsev commented 5 years ago

Hi @nebulousdog, we are waiting for our blog technical maintainer, @dpordomingo, to return from the paternity leave. Once he gets back to work he will certainly review this! Stay tuned and thanks for your contribution.

dpordomingo commented 5 years ago

Hi, the yarn.lock file is already there https://github.com/src-d/blog/blob/master/yarn.lock

Feel free to reopen in case you want to improve the build with new features

dreamalligator commented 5 years ago

thanks! missed that.