Closed vmarkovtsev closed 5 years ago
@vcoisne Added CTA
@campoy All the comments have been addressed.
It appears useless to accept the "suggested changes" on GitHub because each suggestion generates a new commit with apparently unsigned DCO. That's a pain in the ass. cc @mcuadros
Doesn't look to trigger the DCO validation, anyway, this amount of commits for a PR in code repository it's a joke
It did not trigger DCO validation because I "fixed" DCO hehe (before everything came out).
Regarding the number of commits, we can totally do a "squash and merge", don't we?
scheduled for 11/8 @vmarkovtsev
Fixes #221 Staging: https://blog-staging.srcd.run/post/idsplit/