src-d / blog

source{d} blog
https://blog.sourced.tech/
GNU General Public License v3.0
27 stars 41 forks source link

Add the identifier splitter post #257

Closed vmarkovtsev closed 5 years ago

vmarkovtsev commented 5 years ago

Fixes #221 Staging: https://blog-staging.srcd.run/post/idsplit/

vmarkovtsev commented 5 years ago

@vcoisne Added CTA

@campoy All the comments have been addressed.

vmarkovtsev commented 5 years ago

It appears useless to accept the "suggested changes" on GitHub because each suggestion generates a new commit with apparently unsigned DCO. That's a pain in the ass. cc @mcuadros

mcuadros commented 5 years ago

Doesn't look to trigger the DCO validation, anyway, this amount of commits for a PR in code repository it's a joke

vmarkovtsev commented 5 years ago

It did not trigger DCO validation because I "fixed" DCO hehe (before everything came out).

campoy commented 5 years ago

Regarding the number of commits, we can totally do a "squash and merge", don't we?

vcoisne commented 5 years ago

scheduled for 11/8 @vmarkovtsev