search

src-d / blog

source{d} blog
https://blog.sourced.tech/
GNU General Public License v3.0
27 stars 41 forks source link

[WIP] Add “Formatting. With style.” post #273

Closed m09 closed 5 years ago

m09 commented 5 years ago

Thanks for the review @vmarkovtsev!

m09 commented 5 years ago

Thanks for the review @vmarkovtsev :+1:

vmarkovtsev commented 5 years ago

@campoy @vcoisne This is ready for your review.

warenlg commented 5 years ago

question: do we forget to mention it's only working for JS for now, on purpose ?

vmarkovtsev commented 5 years ago

@dpordomingo We've got a build failure here, wdyt... @m09 Can you build locally?

ERROR 2018/12/19 14:22:33 Error while rendering "page": template: theme/_default/single.html:1:3: executing "theme/_default/single.html" at <partial "skeleton" (...>: error calling partial: template: theme/partials/skeleton.html:7:7: executing "theme/partials/skeleton.html" at <partial (printf "ske...>: error calling partial: template: theme/partials/skeleton-single.html:15:15: executing "theme/partials/skeleton-single.html" at <partial "author" $ct...>: error calling partial: template: theme/partials/author.html:24:36: executing "theme/partials/author.html" at <markdownify>: wrong number of args for markdownify: want 1 got 0
vmarkovtsev commented 5 years ago

I see. @m09 Can you please add yourself to https://github.com/src-d/blog/blob/master/data/authors.yml

m09 commented 5 years ago

Thanks @vmarkovtsev it indeed was the problem