Open vcoisne opened 4 years ago
Hi @vcoisne,
I just tried to go and check the document but I have no permission. I just asked for it.
Thank you.
Permissions have been granted.
Thank you!
On Mon, Oct 7, 2019 at 12:20 PM Vadim Markovtsev notifications@github.com wrote:
Permissions have been granted.
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/src-d/blog/issues/312?email_source=notifications&email_token=ADSJSXHWQZZGI3F6WLH2XPLQNMEN7A5CNFSM4IXKHEWKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEAPYOLY#issuecomment-538937135, or mute the thread https://github.com/notifications/unsubscribe-auth/ADSJSXGD2QQBHUPODM464TDQNMEN7ANCNFSM4IXKHEWA .
I am checking the blog issues and in terms of the code insertion, it seems that it wasn't inserted as in the example post. The blog theme is powered with prism.js, which allows to insert the code as a markdown block as explained here:
https://www.matthiggins.dev/ghost-cms-and-syntax-highlighting/
Basically it needs to be introduced with:
```
followed by the language type, e.g. ```language-javascript
I can check the posts with issues to see if I can fix them.
The headers are now fixed. It seems that there was a bug on the theme headers making them uppercase but it is now solved.
I added a fix to make all code blocks work fine, event without using prism.js on markdown, although it would be the best option for a proper highlight of the code.
Thank you @znegrin
If I am following correctly, minus some minor formatting issues (which I can take care of fixing myself), it looks like the only ghost setup issue left is:
cc @vmarkovtsev
Ping @znegrin @vmarkovtsev ?
Hi @vcoisne,
It is now integrated on the blog. I made a quick test to check it out:
To make it sure that it works, the formula code must be inserted as a markdown block.
Please let me know if something particular is waiting for my review @znegrin
Hi @vmarkovtsev,
I basically reviewed and fixed the design issues on the blog side. It probably needs some work on individual posts to make them look better but now from the template side, everything is ready. I fixed these points:
Code blocks background is now working as expected. If using markdown with a language type tag, it will also be highlighted.
Code vertical and horizontal scroll is now fixed too.
I fixed the bug that was showing the titles in uppercase.
I added the proper code to add formulas in markdown using MathJax.
The other issues are meant to be fixed in the content of the individual posts. Please let me know if there is something else design related that need fixing by my side.
Thank you!
@znegrin Regarding the code blocks, the scrollbars should be hidden if they are not needed. For example, at https://blog.sourced.tech/post/handshakes_pagerank/
@znegrin I guess that the following items are design-related:
Regarding the headers, please @ricardobaeta correct me if I am wrong but this is a feature, not a bug.
<body>
must be all lower-case, so css text-transform
<header>
which is shown in the browser's tab must be normal Camel Case.@vcoisne The main complexity now seems to be in porting LaTeX from the old posts. I wonder if we can find somebody to freelance this.
@vmarkovtsev @znegrin integrated MathJax so do we need LaTex ? Happy to help with the updates to get it over with once for all :)
@vcoisne MathJax is a rendering engine for LaTeX.
Thank you @vmarkovtsev for creating this doc with the list of tasks left to finalize a proper ghost setup
https://docs.google.com/spreadsheets/d/15ysW90Onf5cdYV-4SXd-JK7YzjOkLLq8EX6VUbgA4eg/edit#gid=0
@znegrin please review and let me know if you have any questions. More context in this issue: https://github.com/src-d/blog/issues/282