src-d / borges

borges collects and stores Git repositories.
https://docs.sourced.tech/borges/
GNU General Public License v3.0
52 stars 20 forks source link

Travis fails on master (go dep issue) #315

Closed smola closed 6 years ago

smola commented 6 years ago

Sanity checks for non-changed files fail on Travis master. This might require pinning go dep to the latest release instead of using master with go git, just as we did in other projects.

https://travis-ci.org/src-d/borges/jobs/413710734

kuba-- commented 6 years ago

Shall me add make upgrade to Makefile to upgrade go-git for borges (like we did with gitbase and mysql)?

jfontan commented 6 years ago

The problem is that the latest release of go dep has a different lock file output. There's already a CI PR to install only releases instead of master as the output files were changed in master from time to time:

Meanwhile I would update lock file with the latest go dep version.

kuba-- commented 6 years ago

So I hope this can be closed

jfontan commented 6 years ago

I would leave it open until the CI changes are made an we use only releases instead of master.