src-d / borges

borges collects and stores Git repositories.
https://docs.sourced.tech/borges/
GNU General Public License v3.0
52 stars 20 forks source link

Use sane defaults on Docker #320

Closed smola closed 6 years ago

smola commented 6 years ago

From @dennwc (more):

Too many envs. Should use sane defaults instead. CONFIG_ROOT_REPOSITORIES_DIR, CONFIG_DBHOST, LOG_LEVEL are unnecessary.

Similar issue on rovers: https://github.com/src-d/rovers/issues/192

If defaults are good enough, docker container would be able to run with minimal setup (e.g. just some container links to postgres and rabbit).

erizocosmico commented 6 years ago

AFAIK almost all parameters already have defaults. Just adding good defaults to hosts in broker and postgres should be enough