CLI: sync report logic \w Linguist

src-d / enry

A faster file programming language detector

https://blog.sourced.tech/post/enry/

Apache License 2.0

460 stars 51 forks source link

CLI: sync report logic \w Linguist #214

Closed bzz closed 5 years ago

bzz commented 5 years ago

Fixes #204 by adjusting Enry CLI app behavior according to Linguist upstream.

[x] change defaults to show only programming and markup
[x] fix -mode=bytes and make it default, fixes https://github.com/src-d/enry/issues/215

bzz commented 5 years ago

Here is the output of enry from this PR and linguist 7.3.0

$ enry /tmp/linguist-django/django/
95.86%  Python
1.85%   JavaScript
1.65%   HTML
0.63%   CSS
0.01%   Shell
0.00%   Smarty
0.00%   Makefile

$ linguist /tmp/linguist-django/django
95.86%  Python
1.85%   JavaScript
1.65%   HTML
0.63%   CSS
0.01%   Shell
0.00%   Smarty
0.00%   Makefile

\cc @creachadair @dennwc it's ready to be reviewed. As it includes multiple fixes, most probably it easier to do that per-commit.

bzz commented 5 years ago

@creachadair thank you for detailed review! All feedback was addressed and it's ready for another round.

Meanwhile, I'll going to look into CI failures.

bzz commented 5 years ago

CI failure looks irrelevant - they did pass before but then, after the doc update it started to fail on multiple runs on go 1.11 profile.

``` /home/travis/.gimme/versions/go1.11.7.linux.amd64/pkg/tool/linux_amd64/link: running gcc failed: exit status 1 /usr/bin/ld: /tmp/go-link-811669485/000006.o: unrecognized relocation (0x2a) in section `.text' /usr/bin/ld: final link failed: Bad value collect2: error: ld returned 1 exit status ```

If no objections, going to fixing those in a subsequent PRs.