search

src-d / ghsync

GitHub API v3 > PostgreSQL
https://sourced.tech
GNU General Public License v3.0
9 stars 8 forks source link

Do not rely on kallax fork #52

Open carlosms opened 5 years ago

carlosms commented 5 years ago

This project should not rely on @mcuadros fork of kallax.

Maybe there is something we can change to make the code work with the normal kallax, or we may need to submit some PRs to upstream.

mcuadros commented 5 years ago

The most critical thing is https://github.com/mcuadros/go-kallax/commit/18ffe7f4c0c51a09bf7f39c1bf010c3c92a2a8d2 to ignore fields from original structs from go-github, and avoid to write again the structs.

And this one https://github.com/mcuadros/go-kallax/commit/dc0ad3de8cf049828be221db855e2beba96de9c1, is very dirty became introduce the go-git dependency in kallax.