fix files table by removing git log usage

src-d / gitbase

SQL interface to git repositories, written in Go. https://docs.sourced.tech/gitbase

Apache License 2.0

2.07k stars 123 forks source link

fix files table by removing git log usage #920

Closed erizocosmico closed 5 years ago

erizocosmico commented 5 years ago

This may have been what was causing the test failures in gsc.

[x] I updated the documentation explaining the new behavior if any.
[x] I updated CHANGELOG.md file adding the new feature or bug fix.
[x] I updated go-mysql-server using make upgrade command if applicable.
[x] I added or updated examples if applicable.
[x] I checked that changes on schema are reflected into the documentation, if applicable.

erizocosmico commented 5 years ago

can confirm it solves the issue on gsc

kuba-- commented 5 years ago

so there is a bug in git.LogOptions{All: true,} ?

erizocosmico commented 5 years ago

@kuba-- not really, but we changed the behaviour of commit traversing a while ago and we didn't make the change here. Also, it only happens with new borges and old siva files. We have no idea why, but this solves it 🤷‍♂