Use struct tags on commit_stats and commit_file_stats

src-d / gitbase

SQL interface to git repositories, written in Go. https://docs.sourced.tech/gitbase

Apache License 2.0

2.07k stars 123 forks source link

Use struct tags on commit_stats and commit_file_stats #930

Closed erizocosmico closed 5 years ago

erizocosmico commented 5 years ago

Right now all JSON produced by these UDFs has the fields in Uppercase, which is weird when using JSON (specially in Spark, using the struct fields). Should we add some struct tags so it's in snake_lower_case?

WDYT @src-d/data-processing?

ajnavarro commented 5 years ago

As I answered into the PR, I'm concerned about backward compatibility. All queries that are using these functions will stop working with no error message.