search

src-d / go-git

Project has been moved to: https://github.com/go-git/go-git
https://github.com/go-git/go-git
Apache License 2.0
4.91k stars 542 forks source link

fix wildcard handling in RefSpec matching #1160

Closed novas0x2a closed 5 years ago

novas0x2a commented 5 years ago

1) The guard logic here was inverted, resulting in an always-false branch, which meant that the suffix after the wildcard was incorrectly ignored. 2) Wildcards were treated as 1-or-more matches, but git treats them as 0-or-more. This change aligns go-git with git, but represents a bit of a breaking change for go-git.

jfontan commented 5 years ago

I believe that windows tests are failing because a network problem. @mcuadros can you restart the test?