search

src-d / go-git

Project has been moved to: https://github.com/go-git/go-git
https://github.com/go-git/go-git
Apache License 2.0
4.9k stars 540 forks source link

Don't assign err from ForEach loop #1188

Closed muesli closed 5 years ago

muesli commented 5 years ago

Since we don't check the value anyway, as it can't possibly be anything but nil.

mcuadros commented 5 years ago

Thanks for keep go-git clean and tidy. Can you group this batch of PRs in one? Since all are related?

muesli commented 5 years ago

@mcuadros Sure, which ones would you like to see merged? I actually tried to split them up in logical, related pieces already. For example, I don't think simple fixes like this one belong together with changes that actually change behavior, or test-related changes. Up to you though, just let me know.

mcuadros commented 5 years ago

I suggest to merge all in one, since all are about the same nature.

mcuadros commented 5 years ago

I did myself, thanks!