search

src-d / hercules

Gaining advanced insights from Git repository history.
Other
2.63k stars 334 forks source link

'go mod' cannot pull dependencies #229

Closed bobheadxi closed 5 years ago

bobheadxi commented 5 years ago

There seems to be a dependency, imported as github.com/jeffail/tunny, that declares a go.mod file with the module path github.com/Jeffail/tunny (capital J). This causes go mod to break:

❯ go get gopkg.in/src-d/hercules.v9
go: finding github.com/jeffail/tunny latest
go: finding github.com/gogo/protobuf/proto latest
go: finding github.com/gogo/protobuf/sortkeys latest
go: finding github.com/minio/highwayhash latest
go: github.com/jeffail/tunny@v0.0.0-20181108205650-4921fff29480: parsing go.mod: unexpected module path "github.com/Jeffail/tunny"

related: https://github.com/golang/go/issues/27154

vmarkovtsev commented 5 years ago

Ouch... I haven't used modules in Hercules yet, so this went unnoticed. Does it mean that after merging #230 Hercules will be mod-compatible?

bobheadxi commented 5 years ago

It should, though ideally someone would run go mod init to migrate over the Gopkg.lock resolutions as well

I think a new release needs to be tagged though, for the changes to show up in gopkg.in? I'm not familiar with the specifics of how gopkg.in works

Thanks!

vmarkovtsev commented 5 years ago

Pushed v9.1.0

bobheadxi commented 5 years ago

It's working with go mod now - thanks!