Ownership plot still shows ownership after files were deleted

src-d / hercules

Gaining advanced insights from Git repository history.

Other

2.63k stars 334 forks source link

Ownership plot still shows ownership after files were deleted #267

Closed remram44 closed 5 years ago

remram44 commented 5 years ago

A significant portion of my ownership plot is taken from contributors whose files I deleted.

To reproduce:

hercules --burndown --burndown-people --pb https://github.com/VIDA-NYU/reprozip \
| labours -f pb -m ownership -o ownership.png

All files from Manfred Touron were deleted in 2015, but there is no change in the plot.

vmarkovtsev commented 5 years ago

Thanks, I will take a look. Most likely, there is an undeleted branch which still has those files.

vmarkovtsev commented 5 years ago

The files from the pointed commit are actually correctly removed from the stats. However, uml-builder/.config, which appears in 0752cca7abfd1d625db756d0fc7d4e9b881536e0, gets removed during the merge 5da973251d3402230a429d09aa827e51072aeba1. Merge commits are an ownership stats nightmare, investigating further.

vmarkovtsev commented 5 years ago

Yes, the core problem is that I am incorrectly handling full file deletions during merges. Nice one.

remram44 commented 5 years ago

Thank you for the quick fix! I have confirmed that this fixes my problem completely.