src-d / hercules

Gaining advanced insights from Git repository history.
Other
2.06k stars 146 forks source link

--start-date not working #349

Open marverix opened 4 years ago

marverix commented 4 years ago

I'm running command:

labours -i devs.pb -f pb -m devs-efforts --start-date "1 Oct 2018"

But it seems that whatever --start-date doesn't change anything.

vmarkovtsev commented 4 years ago

Hi @marverix

Do you mean the filter does not work or the binary crashes or the result is empty? If the former, is it equivalent to not specifying the filter?

marverix commented 4 years ago

Thanks for reply @vmarkovtsev .

Binary is ok - just results doesn't change. There is no change on graphs if I will set --start-date or not. I tried multiple things like adding also --end-date, other param name like --start... Nothing. I also tried to put some trash like --start-date WOLOOLO and still nothing. But, if I will not give value for param - then it will crash. I didn't dig enough into the code, but it looks for me like it checks for the argument and the value... but doesn't use it?

stevemenke commented 4 years ago

Same happens to me. It looks like there is a disconnect between the CLI passing args to the show_devs function.