src-d / hercules

Gaining advanced insights from Git repository history.
Other
2.63k stars 334 forks source link

Failuer to count couples when both of files have been renamed #367

Open sirogane1013 opened 4 years ago

sirogane1013 commented 4 years ago

Hercules double counts the number of couples when both of coupled files is renamed.

When the commit log is given as follows: Commit1: A FileA A FileB Commit2: M FileA M FileB Commit3: R FileA -> FileA' R FileB -> FileB' Commit4: M FileA' M FileB'

the true number of couple of FileA' and FileB' is 4. However, Hercules counts the co-occurrence in Commit1 and Commit2, so it outputs 6.

vmarkovtsev commented 4 years ago

Thanks! I'll fix this. The project has gone a bit unmaintained recently, but I am planning to resurrect the development :+1: