search

src-d / identity-matching

source{d} extension to match Git signatures to real people.
GNU General Public License v3.0
17 stars 13 forks source link

Add MaxIdentities parameter #44

Closed zurk closed 5 years ago

zurk commented 5 years ago

Based on https://github.com/src-d/eee-identity-matching/pull/42

If a connected component has more than MaxIdentities identities included It cannot be merged with other identities. However, I decided to not use this parameter when we match by external API and email because it is reliable. It is used when matching by name happens.

300 is a default value. I set it when I look at logging output. But we should set it to better value when @EgorBu is done with his experiments in https://github.com/src-d/eee-identity-matching/issues/30

zurk commented 5 years ago

ok, I change it, but there is a test that fails on one of the golang versions. cannot reproduce locally, so it takes some time to debug...