search

src-d / identity-matching

source{d} extension to match Git signatures to real people.
GNU General Public License v3.0
17 stars 13 forks source link

Assume the output format is parquet when the output path points to a parquet file #47

Closed warenlg closed 5 years ago

warenlg commented 5 years ago

Right now the default output format is postgres, so a command like (extracted from the readme https://github.com/src-d/eee-identity-matching#use-without-gitbase):

match-identities \
    --cache path/to/csv/file.csv \
    --output matched_identities.parquet

will write the output to postgres even if the output path points to a parquet file. I think we should set the output format to parquet when such an output path is provided otherwise the arguments are redundant.

vmarkovtsev commented 5 years ago

Our default format must be parquet ofc. No special logic is required really.