search

src-d / kmcuda

Large scale K-means and K-nn implementation on NVIDIA GPU / CUDA
Other
797 stars 146 forks source link

Update python.cc #123

Open mooresethmoore opened 2 years ago

mooresethmoore commented 2 years ago

Missing surrounding parenthesis for if statement on PyTuple_Check for python 3.9 or some versions of DCMAKE or CUDA_ARCH causes a build error.

Signed-off-by: Seth Moore mooresethmoore@gmail.com

vmarkovtsev commented 2 years ago

Thanks, @mooresethmoore! Would you kindly sign the DCO.

lvyilin commented 2 years ago

Compiled successfully with this patch. Thank you!

vincent-mayer commented 2 years ago

@vmarkovtsev are there any plans on merging this? It solved my compilation problem under python 3.9.

vmarkovtsev commented 2 years ago

@vincentmaye If you could copy this fix in another PR and accept DCO, I will immediately merge it :pray: You see, I've got a strong requirement for license purity and cannot accept patches without signed-off-by.